Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies to jupyterlab 2.0, phosphor -> lumino #970

Merged
merged 1 commit into from
Mar 17, 2020
Merged

update dependencies to jupyterlab 2.0, phosphor -> lumino #970

merged 1 commit into from
Mar 17, 2020

Conversation

timkpaine
Copy link
Member

Screen Shot 2020-03-11 at 10 40 04 AM

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Mar 11, 2020
@timkpaine
Copy link
Member Author

@zemeolotu please verify workspaces has no weird bugs (the package change should be name only, its the same version)

@timkpaine timkpaine requested review from zemeolotu and texodus March 11, 2020 14:42
zemeolotu
zemeolotu approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@zemeolotu zemeolotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and workspace works as expected. Thanks!

@texodus
Copy link
Member

texodus commented Mar 17, 2020

Thanks for the PR!

@texodus texodus merged commit 5b4d89d into master Mar 17, 2020
@texodus texodus deleted the jlab2 branch March 17, 2020 02:23
@timkpaine timkpaine mentioned this pull request Mar 17, 2020
Closed
@texodus texodus added internal Internal refactoring and code quality improvement and removed enhancement Feature requests or improvements labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemeolotu zemeolotu zemeolotu approved these changes

@texodus texodus Awaiting requested review from texodus

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkpaine @texodus @zemeolotu @finos-admin