Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerspectiveManager no longer treats str as bytes in Python 2 #965

Merged
merged 1 commit into from
Mar 9, 2020
Merged

PerspectiveManager no longer treats str as bytes in Python 2 #965

merged 1 commit into from
Mar 9, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Mar 9, 2020

This PR fixes a small issue with PerspectiveManager, which treated str return values as bytes and attempted to pass them with the binary kwarg set to True. This broke the copy and download features in JupyterLab when running a Python 2 kernel, specifically when calling to_csv using the widget.

@sc1f sc1f added bug Concrete, reproducible bugs Python labels Mar 9, 2020
texodus
texodus approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

We could probably write a book about py2/3 and C++ integration issues. Or a blog post ...

@texodus texodus merged commit 62c975e into master Mar 9, 2020
@texodus texodus deleted the fix-csv branch March 9, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc1f @texodus @finos-admin