Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully clear queued updates before adding a new computed column #961

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Mar 4, 2020

When a computed column is added, a new Table is created with the computed column, and Perspective internally invalidates and cleans up the old Table.

However, if updates were queued on the old Table and then called for process, the state between the old Table and the new Table (both of which have the computed column) may fall out of sync and cause errors at random.

This PR adds a call to call_process before creating the computed column, ensuring that all queued updates are processed before the old Table is invalidated.

It also reverses a change on the streaming.html example, by reducing the tick rate to something approaching sanity and adding a date column for full type coverage.

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

@texodus texodus merged commit bfbaade into master Mar 4, 2020
@texodus texodus deleted the bucket-fix branch March 4, 2020 16:44
@texodus texodus added bug Concrete, reproducible bugs C++ labels Mar 4, 2020
@texodus
Copy link
Member

texodus commented Mar 17, 2020

Fixes #972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants