Fix column ordering in Python, null handling for computed columns #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides several fixes for issues with
PerspectivePython:pandas.DataFrame, Perspective will read thecolumnsproperty and load the dataframe in the specified order. Perspective will continue to call.keys()for datasets composed of Pythondictandlistvalues, and the canonical way to determine column order should be through creating aViewwith thecolumnskwarg set. This change simply makes Perspective's column layout more symmetrical with that of the provided DataFrame.View, columns included inaggregatesbut not incolumnswill not have their aggregates applied. This fixes issue Pivoted PerspectiveWidget column order broken in Python 2 #904, which occurred because the order of.keys()inaggregates!=the order ofcolumns`.nullto the output column if any value provided to the computed function isnullorundefined.