Make perspective-viewer-hypergrid selection state save/restore compatible
#903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sc1f is this something that should also be exposed in python? |
|
@timkpaine This can't currently be implemented as |
texodus
force-pushed
the
hypergrid-selection-state
branch
from
0ed1677 to
a6783b4
Compare
texodus
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
perspective-viewer-hypergridselection state save/restore compatible.If a row is selected and
saveis called on theperspective-viewer, the config returned will haveplugin_configwith the selected row index. Similarly to restore a selection state, you can callrestorewith the selected row index set on theplugin_configto set the selection state of the grid e.g.viewer.restore({plugin_config: {selected: "row_index"}})This PR also binds the
perspective-selectevent to thefin-row-selection-changedevent instead of thecellClickedcallback. This allows selection events from arrow keys to be captured.