Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @finos/perspective-workspace widget title editable by doubleclick #891

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Make @finos/perspective-workspace widget title editable by doubleclick #891

merged 1 commit into from
Feb 2, 2020

Conversation

zemeolotu
Copy link
Contributor

title

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Jan 30, 2020
texodus
texodus approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus force-pushed the workspace-editable-title branch from b747c71 to 0ae6c9e Compare February 2, 2020 01:22
@texodus texodus merged commit c93ce67 into master Feb 2, 2020
@texodus texodus deleted the workspace-editable-title branch February 2, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin