Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection styling on @finos/perspective-viewer-hypergrid #889

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix selection styling on @finos/perspective-viewer-hypergrid #889

merged 1 commit into from
Jan 30, 2020

Conversation

zemeolotu
Copy link
Contributor

This PR allows the hypergrid selection styling on the tree column to fallback to the same style as the rest of the grid if it's not explicitly set

@zemeolotu zemeolotu requested a review from texodus January 30, 2020 14:04
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Jan 30, 2020
texodus
texodus approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 4504cd6 into master Jan 30, 2020
@texodus texodus deleted the selection-styling-fix branch January 30, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin