Allow missing columns #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
allow-missing-columns
branch
from
cda8abf to
48607bd
Compare
texodus
force-pushed
the
allow-missing-columns
branch
from
48607bd to
b1f4729
Compare
texodus
force-pushed
the
allow-missing-columns
branch
from
b1f4729 to
4d8325c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new column-selection widget for
@finos/perspective-viewerwhich allows columns to be "missing" for fields if the selected plugin specifies it, as well as implementing selected column locking for X/Y chart types which need more than one axis.With this change, D3FC
XY Scatter,Y Scatter,Treemap,Sunburst,Y Lineall support optional arguments and 0-N tooltip columns, and thecolumnsattribute ofperspective-viewermay now containnullwhere supported by the plugin (and ignored otherwise).