Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new package @finos/perspective-workspace #874

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Add new package @finos/perspective-workspace #874

merged 5 commits into from
Jan 28, 2020

Conversation

zemeolotu
Copy link
Contributor

This PR moves all code related to PerspectiveWorkspace from @finos/perspective-phosphor to a new @finos/perspective-workspace package and exposes a new perspective-workspace customElement.

@zemeolotu zemeolotu force-pushed the perspective-workspace branch 5 times, most recently from f5b76ae to dba5fc3 Compare January 17, 2020 18:41
@zemeolotu zemeolotu force-pushed the perspective-workspace branch from dba5fc3 to dd1c5ef Compare January 28, 2020 01:26
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Jan 28, 2020
texodus
texodus approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit c1eb3f7 into master Jan 28, 2020
@texodus texodus deleted the perspective-workspace branch January 28, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin