Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve @finos/perspective-viewer typings #872

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Improve @finos/perspective-viewer typings #872

merged 1 commit into from
Jan 15, 2020

Conversation

zemeolotu
Copy link
Contributor

No description provided.

@zemeolotu zemeolotu requested a review from texodus January 14, 2020 15:18
@texodus
Copy link
Member

texodus commented Jan 15, 2020

Addresses #865

texodus
texodus approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks great!

The Web Component binding modules probably need explicit documentation in the future to note that these exports are types only.

@texodus texodus merged commit a4a524c into master Jan 15, 2020
@texodus texodus deleted the fix-typings branch January 15, 2020 04:23
@texodus texodus added the bug Concrete, reproducible bugs label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zemeolotu @texodus @finos-admin