Add benchmark suite for Python, Refactor module loading for environments where C++ cannot be built #859
Conversation
| >>> func = Benchmark(lambda: self._view.to_records(), meta={ | ||
| "name": "to_records", | ||
| "group": "view" | ||
| }) |
There was a problem hiding this comment.
Are these for use as a decorator?
@Benchmark
def _to_records_test():
self._view.to_records();If so I think the signature of __init__ is wrong - it wouldn't take a func. I see Benchmark is not used as a decorator though here or in the perspective.py benchmarks themselves, but they are referenced as decorator in the docs.
There was a problem hiding this comment.
The docs are a little out of sync; Benchmark wraps a parameterless lambda and a metadata dictionary, which is a simpler implementation I went with instead of decorators.
| with open(arrow_path, "wb") as file: | ||
| arrow = self._table.view().to_arrow() | ||
| file.write(arrow) | ||
| self._WROTE_RESULTS = True |
There was a problem hiding this comment.
It would be nice if this method could incrementally write to an existing arrow so we can locally archive multiple versions, by checking to see if an benchmark.arrow file exists on load. It would also enable cross-language benchmarks in the same archive ..
This PR adds a primitive benchmark suite for
perspective-python, which follows the convention set by the Javascript benchmark suite - it runs operations for Table construction from different datasets, view construction with different pivot settings, and serializing data in all formats from each of those views. Benchmark results are written to aperspective.Tablewhich is hosted via Tornado when the suite finishes (or when Ctrl-C is used to exit the script).Additionally, this PR refactors the module loading semantic for
perspective-python: when the C++ runtime is not present, a reasonable error message is logged, and symbols dependent on the C++ binding will not be exported in the module.PerspectiveWidgetin client mode becomes the only usable symbol, andTable,PerspectiveManager,PerspectiveTornadoHandler, andPerspectiveViewerare not exported at all. A new test module has been added to assert correct behavior in this case.The error message in question:
Finally, minor refactors were made in
to_formatfor performance enhancements.