Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perspective-viewer to allow loading a table before it's attache… #854

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Fix perspective-viewer to allow loading a table before it's attache… #854

merged 1 commit into from
Jan 3, 2020

Conversation

zemeolotu
Copy link
Contributor

…d to the dom

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Dec 19, 2019
texodus
texodus approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 9d848eb into master Jan 3, 2020
@texodus texodus deleted the load-table-before-attach branch January 3, 2020 05:50
@texodus texodus added bug Concrete, reproducible bugs and removed enhancement Feature requests or improvements labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemeolotu @texodus @timkpaine @finos-admin