Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versioning script for Python #852

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Update versioning script for Python #852

merged 2 commits into from
Dec 18, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Dec 18, 2019

This PR changes the versioning script to use the correct value for rc, as well as adding the changed Python version files to Git so that lerna publish can pick them up.

texodus
texodus approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@texodus
Copy link
Member

texodus commented Dec 18, 2019

Thanks for the PR!

@texodus texodus merged commit 94432c2 into master Dec 18, 2019
@texodus texodus deleted the version-python branch December 18, 2019 21:28
@texodus texodus added the internal Internal refactoring and code quality improvement label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc1f @texodus @finos-admin