Set Enums as values for Widget/Viewer, refactor test folder structure #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e structure, add agg/sort/plugin tests
timkpaine
approved these changes
Dec 7, 2019
|
Thanks for the PR and Review! Looks good! |
texodus
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Aggregate,Sort, andPluginenums could be used at__init__for the viewer and widget, but not be set as attributes as they fail Traitlets type checking. This PR overrides__setattr__forPerspectiveViewerto proactively call validate on the Enum, thus converting it to a string before setting it on the instance.Additionally, this PR refactors the test folder structure to match that of the Python source, and adds new tests for the Enums.