Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve user columns and pivots in widget #833

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Preserve user columns and pivots in widget #833

merged 1 commit into from
Dec 4, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Dec 4, 2019

When passing in pandas.MultiIndex to PerspectiveWidget, the parsed columns and pivots take precedence over all kwargs passed in by the user. This PR prefers user input for widgets created from dataframe for columns, row_pivots, and column_pivots.

@timkpaine timkpaine added enhancement Feature requests or improvements Python labels Dec 4, 2019
@texodus
Copy link
Member

texodus commented Dec 4, 2019

Thanks for the PR!

@texodus texodus merged commit e2ab61a into master Dec 4, 2019
@texodus texodus deleted the widget-ux branch December 4, 2019 19:24
@texodus texodus added bug Concrete, reproducible bugs and removed enhancement Feature requests or improvements labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine approved these changes

Assignees
No one assigned
Labels
bug Concrete, reproducible bugs Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sc1f @texodus @timkpaine @finos-admin