Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python build fixes #809

Merged
merged 7 commits into from
Nov 12, 2019
Merged

Python build fixes #809

merged 7 commits into from
Nov 12, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Nov 11, 2019

  • Made python/perspective a lerna-ized package, such that yarn need not be invoked when building for Python from the repo itself.
  • Made zerorpc and bufferutil peerDependencies which are installed when node_modules is not detected during setup, rather than hard deps of package.json. The perspective-python-node module will no longer fail the python build.
  • Moved C++ assets to python/perspective/dist, and fixed clean and build scripts to reference this. A future PR should refine this approach even more, eventually copying all python assets here as well.
  • Merges Typescript and Babel eslint configs, such that phosphor, jupyterlab and perspective-python-node all hav econsistent lint rules.

Also fixes #701

@texodus texodus merged commit 8caf52f into master Nov 12, 2019
@texodus texodus deleted the lint-fixes branch November 12, 2019 01:57
@texodus texodus added bug Concrete, reproducible bugs enhancement Feature requests or improvements and removed enhancement Feature requests or improvements labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in docs
2 participants