Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update declaration #773

Merged
merged 4 commits into from Oct 20, 2019
Merged

Update declaration #773

merged 4 commits into from Oct 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2019

This PR adds the to_arrow and to_columns methods to View and defines a config interface which is used by the various serialization methods. This is based on what's described in the API docs (I'm assuming that's more up to date than what is in the TS declaration).

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@freebroccolo). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If you still have any questions or just don't know what to do next, please email help@finos.org. /CC @finos-admin

@texodus
Copy link
Member

texodus commented Oct 20, 2019

Thanks for the PR!

Annoying how easily our type declarations get out-of-sync with our code - if only we used a language which somehow "checked" our types, and then output the type declaration for us at compile time. Some sort of type checked Javascript - maybe they could call it "JavaTypescript"?

@texodus texodus closed this Oct 20, 2019
@texodus texodus reopened this Oct 20, 2019
@texodus texodus merged commit 0894cd6 into finos:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants