Upgrade Arrow to 0.15.0, link python arrow from prebuilt library #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
requested changes
Oct 14, 2019
There was a problem hiding this comment.
Config header must be modified
https://github.com/finos/perspective/blob/master/cmake/arrow/config.h#L18
timkpaine
previously requested changes
Oct 15, 2019
cmake/modules/FindPyArrow.cmake
Outdated
| @@ -47,6 +47,7 @@ find_path(PYTHON_PYARROW_INCLUDE_DIR arrow/python/api.h | |||
| HINTS "${__pyarrow_path}" "${PYTHON_INCLUDE_PATH}" NO_DEFAULT_PATH) | |||
|
|
|||
| set(PYTHON_PYARROW_LIBRARY_DIR ${__pyarrow_library_dirs}) | |||
| set(PYTHON_PYARROW_SHARED_LIBRARY ${__pyarrow_library_dirs}/libarrow.15${CMAKE_SHARED_LIBRARY_SUFFIX}) | |||
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 50 50
Lines 3359 3359
=======================================
Hits 3090 3090
Misses 269 269Continue to review full report at Codecov.
|
|
Thanks for the PR! Looks Good! I've updated the docker images to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our version of arrow to 0.15.0, and restricts the custom build of arrow + flatbuffers to WASM and C++ only builds.
For Python builds, we link against
libarrow.15.dylibwhich is built when you runpip install pyarrow. Make sure pyarrow is upgraded to the latest version.Works on my machine :)