Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tornado handler for perspective-python #766

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Add tornado handler for perspective-python #766

merged 6 commits into from
Oct 15, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Oct 14, 2019

This PR cleans up the integration of Perspective with web servers in Python:

  • Adds PerspectiveTornadoHandler, which encapsulates the manager and messaging abstractions for use within Tornado.
  • Adds PerspectiveSession, which encapsulates the state of a single websocket connection and removes the wrangling around client_id we have on the JS side.
  • Fixes a bug with date editing in hypergrid
  • Does a little cleanup in the python source

@codecov-io
Copy link

codecov-io commented Oct 14, 2019 •
edited
Loading

Codecov Report

Merging #766 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   92.41%   92.42%   +<.01%     
==========================================
  Files          47       50       +3     
  Lines        3151     3326     +175     
==========================================
+ Hits         2912     3074     +162     
- Misses        239      252      +13
Impacted Files Coverage Δ
perspective/core/viewer.py 98.18% <0%> (-1.82%) ⬇️
perspective/table/table.py 94.28% <0%> (ø) ⬆️
perspective/tests/core/test_validate.py 100% <0%> (ø) ⬆️
perspective/table/__init__.py 100% <0%> (ø) ⬆️
perspective/core/viewer_traitlets.py 100% <0%> (ø) ⬆️
perspective/core/__init__.py 100% <0%> (ø) ⬆️
perspective/tests/core/test_widget.py 100% <0%> (ø) ⬆️
perspective/tests/core/test_viewer.py 100% <0%> (ø) ⬆️
perspective/tests/table/test_manager.py
perspective/table/manager.py
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb146f...d2974a9. Read the comment docs.

@timkpaine
Copy link
Member

👍

@texodus
Copy link
Member

texodus commented Oct 15, 2019

Thanks for the PR and code review!

@texodus texodus merged commit 952a27b into master Oct 15, 2019
@texodus texodus deleted the py-webserver branch October 15, 2019 04:42
@timkpaine timkpaine added enhancement Feature requests or improvements Python labels Oct 15, 2019
@texodus texodus removed the enhancement Feature requests or improvements label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine left review comments

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sc1f @codecov-io @timkpaine @texodus @finos-admin