Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypergrid renderer fixes #764

Merged
merged 6 commits into from
Oct 14, 2019
Merged

Hypergrid renderer fixes #764

merged 6 commits into from
Oct 14, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Oct 14, 2019

Fixes for @finos/perspective-viewer-hypergrid, which in sum greatly improve the user experience of using this plugin in the presence of slow interaciton with the core engine (e.g., when the engine is running on a remote server rather than a WebWorker).

  • Fixed the plugin not appearing when the plugin attribute is toggled via setAttribute().
  • Fixed the viewer flashing when a hover event is triggered before the page can be loaded, e.g. due to large or frequent updates.
  • Fixed various timing-related console.error()s.

@codecov-io
Copy link

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files          47       47           
  Lines        3151     3151           
=======================================
  Hits         2912     2912           
  Misses        239      239

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c73eb2...0cce313. Read the comment docs.

@texodus texodus merged commit 0cb146f into master Oct 14, 2019
@texodus texodus deleted the hypergrid-render-update branch October 14, 2019 03:49
@texodus texodus added the bug Concrete, reproducible bugs label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants