Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python sdist #763

Merged
merged 14 commits into from
Oct 24, 2019
Merged

Python sdist #763

merged 14 commits into from
Oct 24, 2019

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine added enhancement Feature requests or improvements Python labels Oct 13, 2019
@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          50       50           
  Lines        3359     3359           
=======================================
  Hits         3090     3090           
  Misses        269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0894cd6...ebd3b42. Read the comment docs.

@timkpaine
Copy link
Member Author

@texodus dont merge yet, I want to squash and add an sdist install test

@timkpaine timkpaine changed the title allow for pip builds by copy C++ code into folder Python sdist Oct 21, 2019
@texodus
Copy link
Member

texodus commented Oct 24, 2019

Thanks for the PR!

I'll look into modifying this into a package-assembling approach in a future PR.

@texodus texodus merged commit ede03ee into master Oct 24, 2019
@texodus texodus deleted the python_packaging branch October 24, 2019 11:00
@texodus texodus removed the enhancement Feature requests or improvements label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants