Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update bugs #749

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix update bugs #749

merged 2 commits into from
Oct 2, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Oct 2, 2019

  • Remove errant only in perspective.js tests
  • Make sure correct callback indices are removed in global cache
  • Test remove updates

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #749 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #749     +/-   ##
=========================================
- Coverage   91.87%   91.77%   -0.1%     
=========================================
  Files          50       50             
  Lines        3149     3149             
=========================================
- Hits         2893     2890      -3     
- Misses        256      259      +3
Impacted Files Coverage Δ
perspective/table/_date_validator.py 86.84% <0%> (-7.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8702fba...42b0321. Read the comment docs.

@texodus
Copy link
Member

texodus commented Oct 2, 2019

Thanks for the PR! Looks good!

@texodus texodus merged commit d392e46 into master Oct 2, 2019
@texodus texodus deleted the fix-update branch October 2, 2019 19:12
@texodus texodus added the bug Concrete, reproducible bugs label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants