Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users register multiple on_delete callbacks to view and table #747

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

zemeolotu
Copy link
Contributor

No description provided.

@finos-admin
Copy link
Member

Thank you for your pull request and welcome to our community. We require contributors to be identified and we couldn't parse GitHub user details of the following contributors: Zeme Olotu.

In order for your PR to be reviewed and merged, please follow the following directions:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
  4. Amend the authors in the commit history; use git commit --amend to only change last commit, or one between git reset --soft and git rebase to checkout changes, rewrite commit history locally and (force) push changes to the downstream branch

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If you still have any questions or just don't know what to do next, please email help@finos.org. /CC @finos-admin

@timkpaine
Copy link
Member

@finos-admin please fix cla bot

@codecov-io
Copy link

Codecov Report

Merging #747 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   91.82%   91.87%   +0.05%     
==========================================
  Files          49       50       +1     
  Lines        3093     3149      +56     
==========================================
+ Hits         2840     2893      +53     
- Misses        253      256       +3
Impacted Files Coverage Δ
perspective/table/table.py 94.11% <0%> (-0.79%) ⬇️
perspective/tests/table/test_table.py 100% <0%> (ø) ⬆️
perspective/tests/table/test_delete.py 97.29% <0%> (ø)
perspective/table/view.py 81.25% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249b10a...e45ca0d. Read the comment docs.

@texodus
Copy link
Member

texodus commented Sep 30, 2019

Looks good, thanks for the PR!

@texodus texodus merged commit 8702fba into master Sep 30, 2019
@texodus texodus deleted the delete-callbacks branch September 30, 2019 21:36
@maoo
Copy link
Member

maoo commented Oct 1, 2019

@finos-admin please fix cla bot

Dear @timkpaine , this is the expected behaviour of the CLA bot; it seems that @zemeolotu didn't configure the git client used to perform commits in the perspective repo; the comment above walks through few simple steps to help fixing it, please let me know if there's anything unclear.

Without such configuration, GitHub API doesn't return the GitHub ID of the commit's author; you can compare this PR on https://api.github.com/repos/finos/perspective/pulls/747/commits (note that author is null) with https://api.github.com/repos/finos/perspective/pulls/748/commits (where author/login is defined)

Hope this clarifies a bit more. You can find more info about FINOS contribution compliance requirements on our Wiki - https://finosfoundation.atlassian.net/wiki/spaces/FINOS/pages/75530375/Contribution+Compliance+Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants