Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty list in phosphor plugin #745

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Fix empty list in phosphor plugin #745

merged 1 commit into from
Sep 29, 2019

Conversation

timkpaine
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #745 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   91.32%   91.44%   +0.12%     
==========================================
  Files          63       63              
  Lines        3169     3169              
==========================================
+ Hits         2894     2898       +4     
+ Misses        275      271       -4
Impacted Files Coverage Δ
perspective/table/_date_validator.py 97.36% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fd196...04c6056. Read the comment docs.

@texodus
Copy link
Member

texodus commented Sep 29, 2019

Thanks for the PR!

@texodus texodus merged commit de59d3e into master Sep 29, 2019
@texodus texodus deleted the phosphor_bugfix branch September 29, 2019 15:55
@texodus texodus added the bug Concrete, reproducible bugs label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS Jupyter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants