Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes view->plugin rename that didnt make it from original repo #731

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

timkpaine
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          59       59           
  Lines        2141     2141           
=======================================
  Hits         1976     1976           
  Misses        165      165
Impacted Files Coverage Δ
perspective/core/base.py 89.23% <0%> (ø) ⬆️
perspective/core/view.py
perspective/core/plugin.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed64db...9d75cb0. Read the comment docs.

@texodus
Copy link
Member

texodus commented Sep 22, 2019

Thanks for the PR! Looks Great!

@texodus texodus merged commit b3ee97c into finos:master Sep 22, 2019
@timkpaine timkpaine deleted the python_viewfix branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants