Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perspective-viewer cleanup #703

Merged
merged 7 commits into from
Sep 3, 2019
Merged

perspective-viewer cleanup #703

merged 7 commits into from
Sep 3, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 3, 2019

A late-summer cleaning of the <perspective-viewer> web component:

  • Supports missing attributes now, and auto replace empty [] and {} attributes.
  • Removes default shadowing aggregates.
  • Supports boolean attributes for settings and updating.
  • Removed render_time.
  • Fixes serialization of state from save().

This will be a breaking API change for most developers.

@timkpaine
Copy link
Member

@texodus
Copy link
Member Author

texodus commented Sep 3, 2019

No, that is not fixable, attributeChangedCallback does not properly support boolean attributes for web components at present (as also noted in the link). Use toggle_config() instead.

@texodus texodus merged commit 6663686 into master Sep 3, 2019
@texodus texodus deleted the simplify-viewer branch September 3, 2019 02:26
@RandomFractals
Copy link

RandomFractals commented Sep 3, 2019

more breaking api changes?

@texodus can you please document them in your change log this time?

It becomes harder and harder to rely on your viewer lib at this point.

Thanks in advance! Looking forward to your summer break cleanup release :)

P.S: I do hope this is the last set to solidify that viewer api and configs ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants