Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nan filtering, add null filtering #676

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

jspillers
Copy link
Contributor

Filter by null and not null

* Add cases/constants to handle null/not null to emscripten.cpp,
  base.cpp/.h, scalar.cpp, and python.h
* Fix table.cpp so that null values are not skipped when filtering by null
* Alter _is_valid_filter in emscripten.cpp with a special case for
  null/not null so it doesnt reject those filters incorrectly
* Refactor constants.js to allow for accessing filter operators in a
  non magic string way
* Add special condition to row.js filter update so that the operand
  field is hidden when selecting null/not null filter
* Add special condition to perspective.js is_valid_filter so null/not
  null is always valid (operand is irrelevant in this case)
* Add Specs

Remove NaN filtering and related feature flags

* Retain the "true" behavior for nan handling where applicable

* Retain the "true" behavior for nan handling where applicable
* Add cases/constants to handle null/not null to emscripten.cpp,
  base.cpp/.h, scalar.cpp, and python.h
* Fix table.cpp so that null values are not skipped when filtering by null
* Alter _is_valid_filter in emscripten.cpp with a special case for
  null/not null so it doesnt reject those filters incorrectly
* Refactor constants.js to allow for accessing filter operators in a
  non magic string way
* Add special condition to row.js filter update so that the operand
  field is hidden when selecting null/not null filter
* Add special condition to perspective.js is_valid_filter so null/not
  null is always valid (operand is irrelevant in this case)
* Add Specs
@jspillers jspillers changed the title Remove nan filtering add null filtering Remove nan filtering, add null filtering Aug 1, 2019
@texodus
Copy link
Member

texodus commented Aug 2, 2019

Thanks for the PR! Looks good!

@texodus texodus merged commit 8cbd0fd into master Aug 2, 2019
@texodus texodus deleted the remove-nan-filtering-add-null-filtering branch August 2, 2019 16:30
texodus added a commit that referenced this pull request Aug 14, 2019
…ull-filtering"

This reverts commit 8cbd0fd, reversing
changes made to e03dcd4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants