Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #616: perspective-jupyterlab versioning #675

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jul 30, 2019

Adds a build in the version script, which lerna publish will run after updating version numbers but before pushing to the remote. This should update the disted Jupyterlab with the right version of Perspective.

See comment on Lerna issue #1275 for explanation of version lifecycle hook as it relates to Lerna.

@texodus
Copy link
Member

texodus commented Jul 30, 2019

Looks great, thanks for the PR!

@texodus texodus merged commit 4b4b7ea into master Jul 30, 2019
@texodus texodus deleted the fix-jlab-version branch July 30, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants