-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D3 Treemaps #563
Merged
Merged
D3 Treemaps #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify plugin interface code
Support dates on the y-axis for heatmaps
`xRange` is only used within the `on('click`)` callback, so doesn't need to be initialised until a click event happens. Also, we need to only check whether the x-axis is date axis if we actually have an x-axis
Added fixed zoom ranges for date x axis
Zoom y-axis to data on OHLC/Candlestick charts
Initial implemenetation of save and restore
This makes it possible to do a single draw cycle, rather than have to restore settings later and do draw-restore-redraw.
Allow settings to be restored before draw
Minor refactor to settings configuration
Made date zoom button names consistent
Test/more unit tests
Feature/treemap resizing
titling mechanism for gridLayout charts made generic and shared.
…tes of the viewable treemap elements
finos migration
use the native d3 treemap functionality to calculate the new coordina…
provide framework for centering tooltips, and apply to treemap
correct testData file reference
Rename charts
Update results.json to reflect Scatter name change
Overwrite test results
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom to fixed date range
Implementation of Save/Restore functionality to allow Legend size and position to be saved.