Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by hidden #531

Merged
merged 6 commits into from
Apr 9, 2019
Merged

Sort by hidden #531

merged 6 commits into from
Apr 9, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Apr 9, 2019

Refactors the perspective API to

  • Allow sorting by columns missing from the columns config property. These will use a default aggregate if one is not provided in the aggregates property, or "unique" if this column is also in row_pivots or column_pivots property.
  • Default to all columns when the columns property is not set.

Also refactors the plugins to not need this._get_view_hidden()

@texodus texodus merged commit e81aa5f into master Apr 9, 2019
@texodus texodus deleted the sort-by-hidden branch April 9, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant