-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3fc plugin - Label rotation, interpolated legend, zooming, scatter chart things #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modified d3fc axis component is likely to look mostly like this. The multi-axis component may or may not make it into d3. We split the axis into multiple levels in Perspective code, then give that information to the multi-axis
Shape also has to be displayed in the legend
2 types of legend - colour (categories) and symbol (shape and colour) Moved filter functions to their own module
* Apply XY point colour based on mainValue * Add colourRangeLegend to XY chart with colour range * Use newer colourRangeLegend for Heatmap legend and scale
* Set back to reference "cjs" dependency, with yarn focus This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally) * Update to work without global install webpack Must pick webpack 3.5.6 when doing `yarn install --focus` * Silence webpack error relating to "@d3fc/d3fc-data-join" reference
Only currently works for continuous scales (i.e. time series)
…ols.js) - also, reduce padding on y_scatter
Thanks for the PR! Exceptional contribution as per norm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scatter chart things:
NB: The tooltip behaviour on various scatters and lines is generally unideal. We are currently working on an approach more similar to highcharts where it is not necessary to hover over the points themselves - where the tooltip appears for the closest point.