Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3fc plugin - Label rotation, interpolated legend, zooming, scatter chart things #479

Merged
merged 57 commits into from
Mar 11, 2019

Conversation

redbearsam
Copy link
Contributor

Scatter chart things:

  • Shapes for points instead of simple circles when using splits or multi-serie.
  • yScatter chart implemented.
  • x/yScatter using canvas (currently in addition to x/yScatter using svg). This will likely be stripped out later as the performance on the canvas version is better, particularly evidently when zooming. For the time being however, tooltips are not functional on this version, so we're awaiting that feature's completion.

NB: The tooltip behaviour on various scatters and lines is generally unideal. We are currently working on an approach more similar to highcharts where it is not necessary to hover over the points themselves - where the tooltip appears for the closest point.

Andy and others added 30 commits March 8, 2019 12:42
The modified d3fc axis component is likely to look mostly like this. The multi-axis component may or may not make it into d3.

We split the axis into multiple levels in Perspective code, then give that information to the multi-axis
Shape also has to be displayed in the legend
2 types of legend - colour (categories) and symbol (shape and colour)
Moved filter functions to their own module
* Apply XY point colour based on mainValue

* Add colourRangeLegend to XY chart with colour range

* Use newer colourRangeLegend for Heatmap legend and scale
* Set back to reference "cjs" dependency, with yarn focus

This change requires the use of `yarn install --focus" in the perspective-viewer-d3fc folder, if you're only compiling the plugin (so that the dependency with the /cjs folder is pulled in locally)

* Update to work without global install webpack

Must pick webpack 3.5.6 when doing `yarn install --focus`

* Silence webpack error relating to "@d3fc/d3fc-data-join" reference
Only currently works for continuous scales (i.e. time series)
@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Mar 9, 2019
@texodus
Copy link
Member

texodus commented Mar 11, 2019

Thanks for the PR!

Exceptional contribution as per norm!

@texodus texodus merged commit 9f0e89d into finos:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants