Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for filtering datetime columns by string #449

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Feb 25, 2019

  • Verify that we can use correctly-formed date strings to filter datetime columns.
  • Add core engine + plugin tests to prevent regression.

@texodus
Copy link
Member

texodus commented Feb 25, 2019

Thanks for the PR! Tests are always welcome.

@texodus texodus merged commit 28c5625 into master Feb 25, 2019
@texodus texodus deleted the add-filter-tests branch February 26, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants