perspective-webpack-plugin #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a54e43.
…e-webpack-plugin`
@texodus What were the problems this caused? I wasn't aware of anything in the unit tests and build testing I did.
Anything that sets the
What does this mean? When I did a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #398 into a refactor of the webpack build plugin into a new package,
@jpmorganchase/perspective-webpack-plugin.Reverts #391, which emits a double webpack manifest, and re-enables babel compilation in the plugin. Given the problems this has caused, I think an example of a real life problem this configuration causes is going to be necessary before we can consider further attempts to remove it.
Partially reverts #393, as the webpack 4 upgrade conflicts with yarn workspaces without a rebuild. This needs to be saved until the entire project can be upgraded.