Websocket heartbeat detection #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeSheard
reviewed
Jan 21, 2019
|
Thanks for the PR, much appreciated! This is a good feature. I'd like to consider a few ways we can improve this implementation more generally - exposing a custom WebSocket server is easy but will scale poorly as new features are added. Perhaps what we ultimately need to expose here is a simpler binding we can 'mixin' somehow with an arbitrary server defined by the user? Please send us a signed CLA when you can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added heartbeat detection function to websocket to solve the connection interruption of the client due to network or other reasons. When the client connection is disconnected, the invalid connection is cleared on the node side intime