Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cross /src imports in packages #390

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Remove cross /src imports in packages #390

merged 2 commits into from
Jan 23, 2019

Conversation

LukeSheard
Copy link
Contributor

@LukeSheard LukeSheard commented Jan 20, 2019 •
edited
Loading

Remove the cross imported files from /src directories in perspective packages. Useful so that we can build self contained bundles without needing to reach into packages.

  1. Added a comment for usages of COLUMN_SEPARATOR_STRING and replaced with constant.
  2. Replaced detectIE with external detectie package.

@LukeSheard LukeSheard mentioned this pull request Jan 21, 2019
Closed
@timkpaine timkpaine added the JS label Jan 22, 2019
@texodus
Copy link
Member

texodus commented Jan 23, 2019

Thanks for the PR! Tested in IE and works great - I added a small cleanup to remove the commented out code and update yarn.lock

@texodus texodus merged commit 6ddf3e5 into master Jan 23, 2019
@texodus texodus deleted the detectie branch January 23, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeSheard @texodus @timkpaine