Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed type abstractions #355

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Removed type abstractions #355

merged 1 commit into from
Jan 4, 2019

Conversation

texodus
Copy link
Member

@texodus texodus commented Jan 2, 2019

Improve readability by removing unnecessary type abstractions.

@texodus texodus requested review from timkpaine and sc1f January 2, 2019 08:22
timkpaine
timkpaine approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and the cpp-only build works as well (I need to add it to travis)

sc1f
sc1f approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Interested to see the benchmark results for this.

@timkpaine timkpaine mentioned this pull request Jan 3, 2019
Merged
@texodus texodus merged commit 38c4a8d into master Jan 4, 2019
@texodus texodus deleted the remove-types branch January 4, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc1f sc1f sc1f approved these changes

@timkpaine timkpaine timkpaine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texodus @timkpaine @sc1f