New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test quality-of-life updates #354

Merged

texodus merged 1 commit into master from test_refactor

Jan 2, 2019

Contributor

sc1f commented Dec 31, 2018

Add the following flags to the test script:
- --bail: quits after the first test suite failure
- --debug: preserves all console statements
Make order of expect().toEqual() in Perspective.js tests consistent.


          make expect(result).toEqual(expected) consistent throughout suites

texodus force-pushed the test_refactor branch from 10ebb1d to 2383987 Compare

January 2, 2019 03:58

Member

texodus commented Jan 2, 2019

Thanks for the PR!

The mixed-up expect() order was especially annoying - very nice to see this finally fixed!

texodus merged commit 477cf8e into master

texodus deleted the test_refactor branch

January 2, 2019 04:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet