Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seemingly unnecessary install step in README.md #30

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Remove seemingly unnecessary install step in README.md #30

merged 1 commit into from
Feb 7, 2018

Conversation

loicbourgois
Copy link
Contributor

Just cloned and installed, and npm install seems to already run lerna bootstrap --hoist

:~$ git clone git@github.com:loicbourgois/perspective.git
Cloning into 'perspective'...
remote: Counting objects: 1692, done.
remote: Compressing objects: 100% (94/94), done.
remote: Total 1692 (delta 63), reused 112 (delta 49), pack-reused 1543
Receiving objects: 100% (1692/1692), 8.36 MiB | 1.31 MiB/s, done.
Resolving deltas: 100% (871/871), done.
:~$ cd perspective/
:~/perspective$ npm install

> undefined postinstall /home/user/perspective
> lerna bootstrap --hoist

lerna info version 2.8.0
lerna info Bootstrapping 7 packages
lerna info lifecycle preinstall
lerna info Installing external dependencies
lerna info hoist Installing hoisted dependencies into root
lerna info hoist Pruning hoisted dependencies
lerna info hoist Finished pruning hoisted dependencies
lerna info hoist Finished installing in root
lerna info Symlinking packages and binaries
lerna info lifecycle postinstall
lerna info lifecycle prepublish
lerna info lifecycle prepare
lerna success Bootstrapped 7 packages
npm WARN perspective No repository field.
npm WARN perspective No license field.

added 301 packages in 55.464s

So running a second time seems unecessary :

:~/perspective$ ./node_modules/.bin/lerna bootstrap --hoist
lerna info version 2.8.0
lerna info Bootstrapping 7 packages
lerna info lifecycle preinstall
lerna info Installing external dependencies
lerna info hoist Pruning hoisted dependencies
lerna info hoist Finished pruning hoisted dependencies
lerna info hoist Finished installing in root
lerna info Symlinking packages and binaries
lerna info lifecycle postinstall
lerna info lifecycle prepublish
lerna info lifecycle prepare
lerna success Bootstrapped 7 packages

@loicbourgois
Remove unnecessary install step
75379e4 
`npm install` seems to already run `lerna bootstrap --hoist`
@texodus
Copy link
Member

texodus commented Feb 7, 2018

Indeed, thanks for the fix!

@texodus texodus merged commit 5016141 into finos:master Feb 7, 2018
texodus pushed a commit that referenced this pull request Feb 26, 2019
@matt-hooper
Merge pull request #30 from redbearsam/feature/other-cross-scales
0303687 
Add date/time and linear cross-axis scales
@robambalu robambalu mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicbourgois @texodus