Move drag/drop into separate file, clean up row, move detectIE/detectChrome from perspective into perspective-viewer #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc1f
changed the title
of view.js and into separate file, change dragdrop handlers to underscore_naming
texodus
force-pushed
the
row_dragdrop_refactor
branch
from
584f89c to
42612d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view.jsregister_idandregister_callbackpatterndetectIEanddetectChromemoved intoperspective-viewer; I couldn't find anywhere in perspective engine that called it, and since the calls were happening in viewer and highcharts, I moved it into the utils of the viewer.I would have split this into two different branches with different PRs, but the changes were initially made together, making resetting and splitting into different branches difficult.