Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import importlib metadata submodule #2841

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Import importlib metadata submodule #2841

merged 1 commit into from
Nov 10, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Nov 8, 2024

This PR adds an explicit import for importlib.metadata to the perspective.widget module, resolving (?) a reported import exception on Conda (?) environments. While this change is technically correct, the root cause of this module not being cached on these envs remains undetermined. I've included no tests, documentation or description, because I'm a loner rebel who doesn't play by society's rules!

  • Description added retroactively by @texodus. Dictated but not read.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@texodus texodus linked an issue Nov 8, 2024 that may be closed by this pull request
@timkpaine timkpaine marked this pull request as ready for review November 8, 2024 20:15
@texodus texodus added the bug Concrete, reproducible bugs label Nov 10, 2024
@texodus texodus linked an issue Nov 10, 2024 that may be closed by this pull request
@texodus
Copy link
Member

texodus commented Nov 10, 2024

FYI actual import path in my local non-conda environment which caused this to work was to pygments.

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit 992bf93 into master Nov 10, 2024
13 checks passed
@texodus texodus deleted the tkp/importlib branch November 10, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'importlib' has no attribute 'metadata' Failed to import the widget in JupyterLab
2 participants