Fix filter values for non-interned strings #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
fix-filter-interned
branch
from
209ad7b to
e9534be
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
fix-filter-interned
branch
from
e9534be to
926ea29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced In
3.0.0and introduces two tests (one of which fails pre-fix).In this version, the translation layer between a domain-language
ViewConfig(Pythondictor JavaScriptObject) was rewritten and ported to C++, in which we neglected to accommodate fort_tscalar's SSO optimization which inlines string under 13 characters. As this type is used for a filter parameter's term component, this leads to a dangling pointer error when theget_view_config()public method was invoked with a filter value above this limit.Fixes #2781