Fix perspective crate, link perspective-server as static lib
#2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
changed the title
perspective crate, static link perspective-serverperspective crate, statically link perspective-server
texodus
changed the title
perspective crate, statically link perspective-serverperspective crate, link perspective-server as static lib
…thon` Signed-off-by: Andrew Stein <steinlink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2707 split the
perspective-servercrate into a stand-alone.sofor the C++ part of the code base that needed be be built, bundled and imported separately from the Rust client. This fixedperspective-pythonwhen compiled via Emscripten, but broke theperspectveRust crate and caused general build havoc.This PR partially reverts #2707:
perspective-python's duplication of the cmake build logic, src tree cloning, etc.perspective-serverto build the C++ deps as a static lib.perspective-rsto the build and CI system. This library is now built, tested and packaged on CI.perspective-serverinternal C++ library binding, fromcxxto a hand-rolled FFI.