Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerspectiveWidget support for new Python API #2658

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Jul 4, 2024

Adds

  • Support for PerspectiveWidget. Lots of small changes applied, most notably removal of client-only e.g. client=True mode, but some care has been taken to maintain the rudiments of 2.10.1's user-facing API, at least so far. I would like to consider removing the ViewConfig traitlets as well in the future, as restore() is the preferred way to do this from both a usability and performance pov. This component needs a lot more cleanup, this PR just updates the internal API relevant parts.
  • Proper packaging of perspective-jupyterlab client extension assets. These now use maturin's data directory support to package the assets, which are built using jupyter-packaging's labextension install webpack builder.
  • Manylinux builds for linux.
  • aarch64 builds for OSX. I've also added support for this architecture on Linux Provide linux aarch64 wheels #2221, but it is not yet enabled on CI (and hence will not distribute), as I am not sure how we can test it just yet. Suggestions welcome.
  • A rewrite of the project's Github Actions CI script which is substantially faster. The first part of this work was merged in Docs and examples update for new API #2659, but as we did not yet have support for PerspectiveWidget, these steps were omitted from this PR and included here.
  • perspective-server and perspective-client have been reorganized to allow a new variant of the Session type introduced in Perspective Virtual API (Python) #2625, ProxySession, which allows an existing Client instance to itself act as a Session for another Client. This change was necessary to support PerspectiveWidget, as the API was designed for (and remains convenient for) working on Table instances directly, for which the new API prevents access to the originating Server.
  • Removed a number of unused build automations scripts and removed some crufty code generation, such as _version.py in the Python package.
  • Fix perspective-jupyterlab and perspective-python dependency ranges to allow JupyterLab 4. This was already technically supported but will no longer warn of version mismatches.

tomjakubowski and others added 2 commits July 16, 2024 21:18
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus force-pushed the psp3-fix-widget branch 2 times, most recently from ad6e77c to 0577038 Compare July 17, 2024 23:30
@texodus texodus added this to the 3.0 milestone Jul 18, 2024
@texodus texodus force-pushed the psp3-fix-widget branch 17 times, most recently from 8b9d1cf to 856ec02 Compare July 20, 2024 17:20
@texodus texodus force-pushed the psp3-fix-widget branch 4 times, most recently from c9f192d to bff94ef Compare July 23, 2024 16:40
@texodus texodus force-pushed the psp3-fix-widget branch 3 times, most recently from 018475a to 08a6553 Compare July 24, 2024 04:35
No Author and others added 2 commits July 24, 2024 00:46
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
@texodus texodus marked this pull request as ready for review July 24, 2024 04:49
@texodus texodus added the enhancement Feature requests or improvements label Jul 24, 2024
@texodus texodus merged commit 219a6b4 into master Jul 24, 2024
6 checks passed
@texodus texodus deleted the psp3-fix-widget branch July 24, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants