-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perspective Virtual API (Python) #2625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
new-api-python-only
branch
2 times, most recently
from
May 21, 2024 07:26
0d29973
to
2390bc1
Compare
texodus
force-pushed
the
new-api-python-only
branch
5 times, most recently
from
May 27, 2024 23:42
9b4274e
to
7d8d235
Compare
texodus
force-pushed
the
new-api-python-only
branch
from
June 3, 2024 17:52
7d8d235
to
807332b
Compare
Closed
timkpaine
reviewed
Jun 4, 2024
timkpaine
reviewed
Jun 4, 2024
texodus
force-pushed
the
new-api-python-only
branch
from
June 12, 2024 16:56
807332b
to
69c8014
Compare
timkpaine
reviewed
Jun 18, 2024
timkpaine
reviewed
Jun 18, 2024
@@ -16,7 +16,7 @@ | |||
"emscripten": "3.1.54", | |||
"llvm": "17.0.6", | |||
"engines": { | |||
"node": ">=14.18.2 <22" | |||
"node": ">=16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem with this, just note that our build scripts don't work on node 22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why? I run my local build on node 22.
timkpaine
reviewed
Jun 18, 2024
timkpaine
reviewed
Jun 18, 2024
texodus
force-pushed
the
new-api-python-only
branch
13 times, most recently
from
July 3, 2024 02:21
893585f
to
f06783f
Compare
timkpaine
reviewed
Jul 3, 2024
timkpaine
reviewed
Jul 3, 2024
texodus
force-pushed
the
new-api-python-only
branch
14 times, most recently
from
July 4, 2024 19:23
43d2e4f
to
2a76951
Compare
Co-authored-by: Davis Silverman <sinistersnare@users.noreply.github.com> Signed-off-by: Tim Bess <tim@prospective.dev>
Co-authored-by: Davis Silverman <sinistersnare@users.noreply.github.com> Signed-off-by: Tim Bess <tim@prospective.dev>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Co-authored-by: Davis Silverman <sinistersnare@users.noreply.github.com> Signed-off-by: Tim Bess <tim@prospective.dev>
texodus
force-pushed
the
new-api-python-only
branch
from
July 4, 2024 22:32
2a76951
to
b6f57b9
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
new-api-python-only
branch
from
July 4, 2024 22:38
b6f57b9
to
99feef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Library
Building on #2615, this PR updates the Python library bindings. This PR does not include:
PerspectiveWidget
supportPerspectiveWidget
support for new Python API #2658pyodide
build support New APIpyodide
sypport #2660 .Breaking API changes:
date
anddatetime
are not supported by theTable
constructor anymore. These are not valid JSON values and JSON parsing is now language-agnostic. A subsequent PR will add the ability to read JSON strings directly, where this can be overcome as Perspective 2.x did - add a handler for these types to the defaultjson
moduledumps()
function.pandas.DataFrame
is now handled bypyarrow
, which needs to be installed forDataFrame
type to work. Perspective implements no special inference/behavior for these, so it now inheritspyarrow
's semantics regarding column types, precision, etc.Rust Library
As a bonus which came together quite naturally, this PR also introduces a native Rust client and server for Perspective, which allows hosting the Perspective engine in e.g.
axum
, as well as the entirety of the Perspective API as previously implement for JavaScript and Python. The following new crates are introduced:perspective
(native) has been repurposed as the root native-Rust crate, re-exporting the Rust Client and Server APIs as well as conveniences for linking the two with other libraries liketokio
.perspective-python
(native) contains the Python (pyO3) bindings, replacing the old C++ basedperspective-python
.perspective-server
(native) wraps the C++ engine for bothperspective
andperspective-python
.An
axum
server example has also been added to theexamples/
directory.