Fix get_hosted_table_names in Python client #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjakubowski
force-pushed
the
bugfix/py_get_hosted_table_names
branch
from
913c577 to
f4a8af0
Compare
texodus
reviewed
Mar 3, 2024
It was returning None. It now returns a future which resolves to the list of hosted table names.
tomjakubowski
force-pushed
the
bugfix/py_get_hosted_table_names
branch
from
f4a8af0 to
57653ba
Compare
tomjakubowski
commented
Mar 4, 2024
| @@ -64,6 +65,14 @@ async def websocket_client(self): | |||
| """ | |||
| return await websocket(CLIENT, "/websocket") | |||
|
|
|||
| @asynccontextmanager | |||
| async def managed_websocket_client(self): | |||
There was a problem hiding this comment.
I wrote my test first in the style of the others. But when I undid the fix to confirm that would turn my test red, it also made the test hang: when the test is red, await get_hosted_table_names() throws, which exits the test before the client.terminate() call.
So I wrote a tiny async context manager to handle cleaning up the client in that case.
The other tests in this file would also hang if they broke. I can rewrite the other tests in this style if you want
There was a problem hiding this comment.
It was so easy I went ahead and made the change and split it out into a separate commit. Let me know if you'd like any changes
|
Added a test to the starlette integration tests |
texodus
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was returning None. It now returns a future which resolves to the list of hosted table names.