-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint-prettier #242
Add eslint-prettier #242
Conversation
This is great, thanks for the PR! As Perspective is a multi-language project (C++, Javascript and soon Python, plus non-languages like HTML and LESS), I believe it is important to impose at least some basic consistency across the codebase proper where applicable. We'll make a similar request to #224 when I have time to review the
Personally, I am disinterested in the details of code formatting outside of consistency - assuming you concur, would you mind amending this commit by adding the above 2 overrides to the |
Very reasonable request. I was also unsure about I'll update the options now and re-run babb867. |
With similar intentions to #224 this adds
eslint-config-prettier
andeslint-plugin-prettier
to the eslint config, and adds a pre-commit hook which automatically formats all the javascript files for you.