Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols column in XY-scatter plot #2373

Closed
wants to merge 4 commits into from

Conversation

ada-x64
Copy link
Contributor

@ada-x64 ada-x64 commented Oct 4, 2023

This PR aims to create a Symbols column field in the XY-scatter plot allowing users to specify a mapping between specific row values and symbols. Currently this only supports the basic d3 filled symbols, but in the future we may extend this to allow custom symbols.

CHANGES:

  • Rename default_config plugin field to plugin_attributes and extend its functionality. It now handles general purpose plugin attributes, which determine which attribute and style fields show up in the sidebar.
  • Add plugin_attributes to the d3fc plugin and update its restore and save methods to communicate with the viewer.
  • Create a "symbols" key-value mapping section in the column settings sidebar's styles tab.
  • Rearrange some files in the column settings sidebar for clarity.
  • Allow CustomEvents to be triggered from a model, and use this to send configs to/from plugins.
  • Always show the Attributes tab; add the "Type" section, and disabled the expression editor for non-expression columns.
  • Address view/session and FFI concerns in fix gradient values #2384
  • Add tests

TODO:

  • Style the symbol attribute section + general UX improvements
  • Check edge cases
  • Ensure the plugin maps symbols based on the symbol field (this is currently working for legends but not the chart itself)
  • Override certain values based on the passed symbols config
  • Add and update tests!

KNOWN ISSUES:

  • Incompatible with color-by
  • Incompatible with filter (where)
  • Incompatible with split-by
  • Incorrect behavior with group-by

@ada-x64 ada-x64 force-pushed the symbols-column-xyscatter branch 2 times, most recently from 387e7bc to b51114f Compare October 9, 2023 20:03
@ada-x64 ada-x64 marked this pull request as ready for review October 9, 2023 20:07
@ada-x64 ada-x64 force-pushed the symbols-column-xyscatter branch 2 times, most recently from 1a9b0d9 to 38c36b8 Compare October 10, 2023 19:10
add plugin_attributes api
add CustomEvents model
move plugin config functions to model
fix ui bugs

basic symbol tests
don't fail on numeric and datetime symbol values
@ada-x64 ada-x64 force-pushed the symbols-column-xyscatter branch from 6bcc47c to 3f613ec Compare October 12, 2023 14:19
@ada-x64
Copy link
Contributor Author

ada-x64 commented Oct 16, 2023

ada-x64#1
ada-x64#2
These should go on top before merging.

@texodus
Copy link
Member

texodus commented Oct 20, 2023

Closing for #2394

@texodus texodus closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants