Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python dependency versions #2327

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Pin Python dependency versions #2327

merged 1 commit into from
Aug 7, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Aug 6, 2023

Pins Python dependencies per-version via pip freeze. Without this, Perspective's Python builds are subject to capricious breakage as is the case currently on master, a critical aspect of reproducible builds. Because there is no set of specific dependencies which satisfy 3.7 through 3.11, we have a separate requirements-XXX.txt per Python version we support, each with the latest compatible dependency versions. There's currently no mechanism for updating these files except re-running pip install per version, which even with pyenv takes eons (though this may be developer ignorance).

Full build

@texodus texodus added the internal Internal refactoring and code quality improvement label Aug 6, 2023
@texodus texodus merged commit 4283081 into master Aug 7, 2023
@texodus texodus deleted the pin-python-dependencies branch August 7, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant