1D charts generated from columnar data #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc1f
force-pushed
the
column_charting
branch
from
583028d to
9df5847
Compare
texodus
reviewed
Sep 12, 2018
.travis.yml
Outdated
| @@ -29,7 +29,6 @@ install: | |||
| - npm install | |||
|
|
|||
| script: | |||
| - npm run lint | |||
There was a problem hiding this comment.
This seems like it was picked up from a merge - should be cleaned up please!
sc1f
force-pushed
the
column_charting
branch
from
9df5847 to
d993342
Compare
|
FIXME: charts should not flash on re-render. |
sc1f
force-pushed
the
column_charting
branch
from
dca8a3a to
40e30d8
Compare
…over row-based series generation
sc1f
force-pushed
the
column_charting
branch
from
c455d1e to
ffe31e1
Compare
|
Looks good, this is a great addition, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge only after
to_columncorrectly strips total rows. I included a.filter()insideColumnarIteratorthat can be removed in order to verify that total rows are stripped.