Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocks example server #2282

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix blocks example server #2282

merged 1 commit into from
Jun 30, 2023

Conversation

brochington
Copy link
Contributor

This PR fixes a bug where the blocks server could not be started with the command yarn start blocks.

texodus
texodus approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

Good catch - this was a blockhead mistake by me, suffered because it is common in Perspective development to just run this static file server in the background in effective perpetuity.

@texodus texodus merged commit 23aeb41 into finos:master Jun 30, 2023
@texodus texodus added the internal Internal refactoring and code quality improvement label Jun 30, 2023
@texodus texodus changed the title Fix bug preventing blocks example server from starting. Fix blocks example server Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus texodus approved these changes

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brochington @texodus